定期イベントの内容が更新されたら参加者に通知する #5768
Merged
定期イベントの内容が更新されたら参加者に通知する #5768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikarook94
force-pushed
the
feature/notify-when-regular-events-change
branch
from
9686ebf
to
6d8e227
Compare
|
@shucream-p |
|
@hikarook94 遅くて11/13までにはお返事できるかと思いますがいかがでしょうか？ |
|
@shucream-p |
|
@hikarook94 |
shucream-p
approved these changes
Nov 13, 2022
There was a problem hiding this comment.
@hikarook94
お疲れ様です！遅くなってしまいすみません🙇♂️
こちら動作とコード確認しました。問題ないと思いますのでApproveさせていただきます！
|
@shucream-p |
|
@komagata |
komagata
reviewed
Nov 14, 2022
app/models/notification.rb
Outdated
| @@ -36,7 +36,8 @@ class Notification < ApplicationRecord | |||
| product_update: 17, | |||
| graduated: 18, | |||
| hibernated: 19, | |||
| signed_up: 20 | |||
| signed_up: 20, | |||
| regular_event: 21 | |||
There was a problem hiding this comment.
ここは通知イベントの名前（動詞）で統一されているのでregular_eventだと何が起こったのかわからないので他の名前を考えてみてください〜
There was a problem hiding this comment.
動詞形に修正しました！ご確認よろしくお願いします！
hikarook94
force-pushed
the
feature/notify-when-regular-events-change
branch
from
6d8e227
to
1348fd1
Compare
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
概要
定期イベントの詳細が更新された時、参加者にアプリ内通知とメール通知を送信するように変更しました。
見た目の変更はありません。
変更確認方法
feature/notify-when-regular-events-changeをローカルに取り込むbin/rails sでローカル環境を立ち上げるkimuraでログインするhttp://localhost:3000/regular_events/459650222にアクセスして、参加申込をするkomagataでログインし直すhttp://localhost:3000/regular_events/459650222にアクセスして、内容を変更する（開催曜日を変更する等で大丈夫です）kimuraでログインするhttp://localhost:3000/notificationsにアクセスして定期イベントが更新された通知がきていればOKhttp://localhost:3000/letter_openerを開き、kimura宛に定期イベント更新のメールが来ていればOK